linux-kernel - Re: [PATCH] mm/hugetlb: Fix build with !ARCH_WANT_HUGE_PMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210310194014.GE6530@xz-x1>
Date:   Wed, 10 Mar 2021 14:40:14 -0500
From:   Peter Xu <peterx@...hat.com>
To:     Mike Kravetz <mike.kravetz@...cle.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Subject: Re: [PATCH] mm/hugetlb: Fix build with !ARCH_WANT_HUGE_PMD_SHARE

On Wed, Mar 10, 2021 at 11:21:50AM -0800, Mike Kravetz wrote:
> On 3/10/21 10:53 AM, Peter Xu wrote:
> > want_pmd_share() is undefined with !ARCH_WANT_HUGE_PMD_SHARE since it's put
> > by accident into a "#ifdef ARCH_WANT_HUGE_PMD_SHARE" block.  Moving it out
> > won't work either since vma_shareable() is only defined within the block.
> > Define it for !ARCH_WANT_HUGE_PMD_SHARE instead.
> > 
> > Fixes: 5b109cc1cdcc ("hugetlb/userfaultfd: forbid huge pmd sharing when uffd enabled")
> 
> That commit id is from Andrew's tree and I don't think it is stable.
> There is a different id in the next tree.  Not exactly sure how this is
> supposed to be handled.

I see - it'll be even better if this patch can be squashed into it.

> 
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Mike Kravetz <mike.kravetz@...cle.com>
> > Cc: Axel Rasmussen <axelrasmussen@...gle.com>
> > Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> > Tested-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> > Signed-off-by: Peter Xu <peterx@...hat.com>
> > ---
> >  mm/hugetlb.c | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> Thanks Peter,
> Not your fault, but that header file is a bit of a mess.
> 
> Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

I'm still guilty on not noticing this before since I still could..  I think it
gives me some more clue to make less such mistake in the future.

Thanks for taking a quick look, Mike!

-- 
Peter Xu