linux-kernel - Re: [PATCH v5 4/5] proc: Relax check of mount visibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 03:42:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alexey Gladkov <gladkov.alexey@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "Eric W . Biederman" <ebiederm@...ssion.com>
Cc:     kbuild-all@...ts.01.org, Alexey Gladkov <legion@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Kees Cook <keescook@...omium.org>,
        Linux Containers <containers@...ts.linux-foundation.org>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v5 4/5] proc: Relax check of mount visibility

Hi Alexey,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on kees/for-next/pstore linus/master v5.12-rc2 next-20210310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alexey-Gladkov/proc-Relax-check-of-mount-visibility/20210311-022252
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 144c79ef33536b4ecb4951e07dbc1f2b7fa99d32
config: powerpc-randconfig-s032-20210309 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-262-g5e674421-dirty
        # https://github.com/0day-ci/linux/commit/57a1fff647a507e103bbe22d67c6fe6b54c6a088
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexey-Gladkov/proc-Relax-check-of-mount-visibility/20210311-022252
        git checkout 57a1fff647a507e103bbe22d67c6fe6b54c6a088
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/proc/root.c: In function 'proc_reconfigure':
>> fs/proc/root.c:233:11: error: 'fs_info' undeclared (first use in this function); did you mean 'qc_info'?
     233 |  put_cred(fs_info->mounter_cred);
         |           ^~~~~~~
         |           qc_info
   fs/proc/root.c:233:11: note: each undeclared identifier is reported only once for each function it appears in


vim +233 fs/proc/root.c

97412950b10e64 Vasiliy Kulikov 2012-01-10  226  
66f592e2ece038 David Howells   2018-11-01  227  static int proc_reconfigure(struct fs_context *fc)
97412950b10e64 Vasiliy Kulikov 2012-01-10  228  {
66f592e2ece038 David Howells   2018-11-01  229  	struct super_block *sb = fc->root->d_sb;
02b9984d640873 Theodore Ts'o   2014-03-13  230  
02b9984d640873 Theodore Ts'o   2014-03-13  231  	sync_filesystem(sb);
66f592e2ece038 David Howells   2018-11-01  232  
b84f25e5938b65 Alexey Gladkov  2021-03-10 @233  	put_cred(fs_info->mounter_cred);
b84f25e5938b65 Alexey Gladkov  2021-03-10  234  	fs_info->mounter_cred = get_cred(fc->cred);
b84f25e5938b65 Alexey Gladkov  2021-03-10  235  
57a1fff647a507 Alexey Gladkov  2021-03-10  236  	return proc_apply_options(sb, fc, current_user_ns());
97412950b10e64 Vasiliy Kulikov 2012-01-10  237  }
97412950b10e64 Vasiliy Kulikov 2012-01-10  238  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (28560 bytes)