linux-kernel - Re: [PATCH 1/3] PCI: controller: al: select CONFIG_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2tNAqjSSP4g6dguT58C4DUGUT4Jgf-Osa1Da03cecLRQ@mail.gmail.com>
Date:   Wed, 10 Mar 2021 22:02:55 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh@...nel.org>,
        linux-pci <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] PCI: controller: al: select CONFIG_PCI_ECAM

On Wed, Mar 10, 2021 at 8:32 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Mon, Mar 08, 2021 at 04:24:46PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > Compile-testing this driver without ECAM support results in a link
> > failure:
> >
> > ld.lld: error: undefined symbol: pci_ecam_map_bus
> > >>> referenced by pcie-al.c
> > >>>               pci/controller/dwc/pcie-al.o:(al_pcie_map_bus) in archive drivers/built-in.a
> >
> > Select CONFIG_ECAM like the other drivers do.
>
> Did we add these compile issues in the v5.12-rc1?  I.e., are the fixes
> candidates for v5.12?

No, the bug exists but is hidden until you apply patch 3/3 because the
driver is never compile tested on anything other than arm64, which
turns on PCI_ECAM unconditionally.

Merging all three for 5.13 is sufficient.

       Arnd