linux-kernel - Re: [PATCH v2 1/1] gpio: Support interrupts in gpio-mlxbf2.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202103110608.NJ53kxIS-lkp@intel.com>
Date:   Thu, 11 Mar 2021 06:53:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Asmaa Mnebhi <Asmaa@...lanox.com>, linus.walleij@...aro.org,
        bgolaszewski@...libre.com
Cc:     kbuild-all@...ts.01.org, Asmaa Mnebhi <asmaa@...dia.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] gpio: Support interrupts in gpio-mlxbf2.c

Hi Asmaa,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on gpio/for-next]
[also build test WARNING on v5.12-rc2 next-20210310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Asmaa-Mnebhi/gpio-Support-interrupts-in-gpio-mlxbf2-c/20210311-031707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8495cb2b31bda48cb427278a04332bc2d57a1614
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Asmaa-Mnebhi/gpio-Support-interrupts-in-gpio-mlxbf2-c/20210311-031707
        git checkout 8495cb2b31bda48cb427278a04332bc2d57a1614
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpio/gpio-mlxbf2.c: In function 'mlxbf2_gpio_send_work':
   drivers/gpio/gpio-mlxbf2.c:336:2: error: implicit declaration of function 'acpi_bus_generate_netlink_event' [-Werror=implicit-function-declaration]
     336 |  acpi_bus_generate_netlink_event("button/power.*", "Power Button",
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpio/gpio-mlxbf2.c:332:30: warning: variable 'gs' set but not used [-Wunused-but-set-variable]
     332 |  struct mlxbf2_gpio_context *gs;
         |                              ^~
   cc1: some warnings being treated as errors


vim +/gs +332 drivers/gpio/gpio-mlxbf2.c

   329	
   330	static void mlxbf2_gpio_send_work(struct work_struct *work)
   331	{
 > 332		struct mlxbf2_gpio_context *gs;
   333	
   334		gs = container_of(work, struct mlxbf2_gpio_context, send_work);
   335	
 > 336		acpi_bus_generate_netlink_event("button/power.*", "Power Button",
   337						0x80, 1);
   338	}
   339	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (67782 bytes)