linux-kernel - Re: [PATCH v2 0/3] Fix bugs related to TPM2 event log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 01:04:13 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Stefan Berger <stefanb@...ux.ibm.com>
Cc:     peterhuewe@....de, jgg@...pe.ca, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Fix bugs related to TPM2 event log

On Wed, Mar 10, 2021 at 05:19:13PM -0500, Stefan Berger wrote:
> This series of patches fixes a couple of issues related to TPM2
> event logs, such as the disappearance of the TPM2 log on QEMU machines
> running with UEFI (my fault) and a kernel fault due to an integer under-
> flow when reading the TPM 2 log multiple times.
> 
> Regards,
>    Stefan
> 
> v1->v2:
>  - Revised patches 1 & 2
> 
> Stefan Berger (3):
>   tpm: efi: Use local variable for calculating final log size
>   tpm: acpi: Check eventlog signature before using it
>   tpm: vtpm_proxy: Avoid reading host log when using a virtual device
> 
>  drivers/char/tpm/eventlog/acpi.c   | 33 +++++++++++++++++++++++++++++-
>  drivers/char/tpm/eventlog/common.c |  3 +++
>  drivers/char/tpm/eventlog/efi.c    | 29 ++++++++++++++++++--------
>  3 files changed, 56 insertions(+), 9 deletions(-)
> 
> -- 
> 2.29.2
> 
> 

b4 seems like remarkably useful tool:

$ b4 am 20210310221916.356716-1-stefanb@...ux.ibm.com
Looking up https://lore.kernel.org/r/20210310221916.356716-1-stefanb%40linux.ibm.com
Grabbing thread from lore.kernel.org/linux-integrity
Analyzing 4 messages in the thread
---
Writing ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx
  ✓ [PATCH v2 1/3] tpm: efi: Use local variable for calculating final log size
  ✓ [PATCH v2 2/3] tpm: acpi: Check eventlog signature before using it
  ✓ [PATCH v2 3/3] tpm: vtpm_proxy: Avoid reading host log when using a virtual device
  ---
  ✓ Attestation-by: DKIM/ibm.com (From: stefanb@...ux.ibm.com)
---
Total patches: 3
---
Cover: ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.cover
 Link: https://lore.kernel.org/r/20210310221916.356716-1-stefanb@linux.ibm.com
 Base: not found (applies clean to current tree)
       git am ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx

$ git am -3 v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx
Applying: tpm: efi: Use local variable for calculating final log size
Applying: tpm: acpi: Check eventlog signature before using it
Applying: tpm: vtpm_proxy: Avoid reading host log when using a virtual device

I also did run checkpatch.pl, no errors.

/Jarkko