linux-kernel - Re: [PATCH v8 3/4] arm64: dts: mediatek: add mt6765 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1615356318.4818.5.camel@mtkswgap22>
Date:   Wed, 10 Mar 2021 14:05:18 +0800
From:   Macpaul Lin <macpaul.lin@...iatek.com>
To:     Chun-Kuang Hu <chunkuang.hu@...nel.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        "Michael Turquette" <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        mtk01761 <wendell.lin@...iatek.com>,
        Fabien Parent <fparent@...libre.com>,
        Weiyi Lu <weiyi.lu@...iatek.com>,
        Mars Cheng <mars.cheng@...iatek.com>,
        Sean Wang <Sean.Wang@...iatek.com>,
        Owen Chen <owen.chen@...iatek.com>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Evan Green <evgreen@...omium.org>,
        Yong Wu <yong.wu@...iatek.com>, Joerg Roedel <jroedel@...e.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Marc Zyngier <marc.zyngier@....com>,
        Ryder Lee <Ryder.Lee@...iatek.com>,
        DTML <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>, <linux-clk@...r.kernel.org>,
        CC Hwang <cc.hwang@...iatek.com>,
        Loda Chou <loda.chou@...iatek.com>,
        Mediatek WSD Upstream <wsd_upstream@...iatek.com>
Subject: Re: [PATCH v8 3/4] arm64: dts: mediatek: add mt6765 support

On Wed, 2021-03-10 at 00:08 +0800, Chun-Kuang Hu wrote:
> Hi, Macpaul:
> 
> Macpaul Lin <macpaul.lin@...iatek.com> 於 2020年2月21日 週五 下午6:22寫道：
> >
> > From: Mars Cheng <mars.cheng@...iatek.com>
> >
> > Add basic chip support for Mediatek 6765, include
> > uart node with correct uart clocks, pwrap device
> >
> > Add clock controller nodes, include topckgen, infracfg,
> > apmixedsys and subsystem.
> >
> > Signed-off-by: Mars Cheng <mars.cheng@...iatek.com>
> > Signed-off-by: Owen Chen <owen.chen@...iatek.com>
> > Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> > Acked-by: Marc Zyngier <marc.zyngier@....com>
> > ---
> >  arch/arm64/boot/dts/mediatek/Makefile       |    1 +
> >  arch/arm64/boot/dts/mediatek/mt6765-evb.dts |   33 ++++
> >  arch/arm64/boot/dts/mediatek/mt6765.dtsi    |  253 +++++++++++++++++++++++++++
> >  3 files changed, 287 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt6765-evb.dts
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt6765.dtsi

[deleted]

> > +
> > +               mmsys_config: syscon@...00000 {
> > +                       compatible = "mediatek,mt6765-mmsys", "syscon";
> > +                       reg = <0 0x14000000 0 0x1000>;
> > +                       interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_LOW>;
> 
> I does not see interrupts property in binding document [1], please add
> this in binding document first.
> I'm curious about this interrupt. In which condition would it be triggered?
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt?h=v5.12-rc2
> 
> Regards,
> Chun-Kuang.

Thanks for reminding.
I'll remove interrupts binding in next version and leave it for mmsys
driver owner to update when the configuration of mmsys driver is
enabled.

[...]


> > +               smi_common: smi_common@...02000 {
> > +                       compatible = "mediatek,mt6765-smi-common", "syscon";
> > +                       reg = <0 0x14002000 0 0x1000>;
> > +               };
> > +

@Yong Wu
Thanks for reviewing here, I'll replace smi_common@...02000 to
smi@...02000

Regards,
Macpaul Lin