linux-kernel - Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16010cff-0fcb-ade6-1e0c-1a4dbb5a7b2f@gmail.com>
Date:   Wed, 10 Mar 2021 11:47:19 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     zhangqing <zhangqing@...ngson.cn>, Marc Zyngier <maz@...nel.org>
Cc:     Huacai Chen <chenhuacai@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        wangming01@...ngson.cn
Subject: Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

Hello!

On 10.03.2021 5:26, zhangqing wrote:

[...]
>> +    if (of_device_is_compatible(node, "loongson,liointc-2.0")) {
>> +        base = liointc_get_reg_byname(node, "main");
>> +        if (!base) {
>> +            err = -ENODEV;
>> +            goto out_free_priv;
>> +        }
>> +        for (i = 0; i < LIOINTC_NUM_CORES; i++) {
>> +            priv->core_isr[i] =
>> +                liointc_get_reg_byname(node, core_reg_names[i]);
>> Please write assignments on a single line.
> 
> In addition, write assignments on a single line
> 
>                   for (i = 0; i <LIOINTC_NUM_CORES; i++)
>                           priv->core_isr[i] = liointc_get_reg_byname(node, 
> core_reg_names[i]);
> 
>      It is 92 characters, more than 80 characters...

    The new line length limit is 100 chars. :-)

[...]

MBR, Sergei