linux-kernel - Re: [PATCH] char/mwave: turn tp3780I_InitializeBoardData() into void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Mar 2021 09:52:02 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char/mwave: turn tp3780I_InitializeBoardData() into void
 function

On Wed, Mar 10, 2021 at 04:46:03PM +0800, Yang Li wrote:
> This function always return '0' and no callers use the return value.
> So make it a void function.
> 
> This eliminates the following coccicheck warning:
> ./drivers/char/mwave/tp3780i.c:182:5-11: Unneeded variable: "retval".
> Return "0" on line 187
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/char/mwave/tp3780i.c | 6 +-----
>  drivers/char/mwave/tp3780i.h | 2 +-
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/char/mwave/tp3780i.c b/drivers/char/mwave/tp3780i.c
> index 5e1618a..8588b51 100644
> --- a/drivers/char/mwave/tp3780i.c
> +++ b/drivers/char/mwave/tp3780i.c
> @@ -177,14 +177,10 @@ int tp3780I_InitializeBoardData(THINKPAD_BD_DATA * pBDData)
>  	return retval;
>  }
>  
> -int tp3780I_Cleanup(THINKPAD_BD_DATA * pBDData)
> +void tp3780I_Cleanup(THINKPAD_BD_DATA *pBDData)

Your subject line does not match what the patch does :(