linux-kernel - Re: [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210310090559.GI4931@dell>
Date:   Wed, 10 Mar 2021 09:05:59 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     'Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Lubomir Rintel <lkundrak@...sk>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next RESEND] mfd: ene-kb3930: Make symbol
 'kb3930_power_off' static

On Mon, 08 Mar 2021, 'Wei Yongjun wrote:

> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> The sparse tool complains as follows:
> 
> drivers/mfd/ene-kb3930.c:36:15: warning:
>  symbol 'kb3930_power_off' was not declared. Should it be static?
> 
> This symbol is not used outside of ene-kb3930.c, so this
> commit marks it static.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> Acked-by: Lubomir Rintel <lkundrak@...sk>

This should have been a Reviewed-by.

> ---
>  drivers/mfd/ene-kb3930.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog