linux-kernel - Re: [PATCH v10 0/8] Add support for ipq8064 tsens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72427874-244b-6344-411c-ea53770bc1f0@linaro.org>
Date:   Wed, 10 Mar 2021 14:40:28 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Thara Gopinath <thara.gopinath@...aro.org>,
        Ansuel Smith <ansuelsmth@...il.com>,
        Amit Kucheria <amitk@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 0/8] Add support for ipq8064 tsens

On 10/03/2021 14:32, Thara Gopinath wrote:
> 
> 
> On 3/10/21 7:19 AM, Daniel Lezcano wrote:
>>
>> Hi Ansuel,
>>
>> On 17/02/2021 20:40, Ansuel Smith wrote:
>>> This patchset convert msm8960 to reg_filed, use int_common instead
>>> of a custom function and fix wrong tsens get_temp function for msm8960.
>>> Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs
>>> to be registered as a gcc child as the tsens regs on this platform are
>>> shared with the controller.
>>> This is based on work and code here
>>> https://git.linaro.org/people/amit.kucheria/kernel.git/log/?h=wrk3/tsens-8960-breakage
>>>
>>
>> I don't have major concerns with the series except there is no comment
>> from the maintainer / reviewer of the sensor.
>>
>> Given it is based on Amit's work, I can assume they are correct.
>>
>> I added Thara in Cc hoping she has time to review the changes. If nobody
>> complains with the series, I'll merge them in the next days
> 
> Hi Ansuel/Daniel,
> 
> Just wanted to let you know that I have started looking into this and
> review this within next week or two.

Great, thank you


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog