[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <XRBRPQ.2KHLLNUGZDFB1@crapouillou.net>
Date: Wed, 10 Mar 2021 14:19:09 +0000
From: Paul Cercueil <paul@...pouillou.net>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: 周琰杰 <zhouyanjie@...yeetech.com>,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh+dt@...nel.org>, linux-mips@...r.kernel.org,
GPIO SUBSYSTEM <linux-gpio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
"H. Nikolaus Schaller" <hns@...delico.com>, paul@...die.org.uk,
dongsheng.qiu@...enic.com, aric.pzqi@...enic.com,
sernia.zhou@...mail.com
Subject: Re: [PATCH 1/3] pinctrl: Ingenic: Fix bug and reformat the code.
Le mer. 10 mars 2021 à 16:03, Andy Shevchenko
<andy.shevchenko@...il.com> a écrit :
> On Tue, Mar 9, 2021 at 6:42 PM 周琰杰 (Zhou Yanjie)
> <zhouyanjie@...yeetech.com> wrote:
>>
>> 1.Add tabs before values to align the code in the macro definition
>> section.
>> 2.Fix bugs related to the MAC of JZ4770, add missing pins to the
>> MII group.
>> 3.Adjust the sequence of X1830's SSI related codes to make it
>> consistent
>> with other Ingenic SoCs.
>> 4.Fix bug in "ingenic_pinconf_get()", so that it can read the
>> configuration
>> of X1830 SoC correctly.
>>
>
> Split to 4 patches then.
> It's quite hard for everybody to handle regression fixes like this.
Agreed. And the fixes should have a Fixes: tag.
-Paul
Powered by blists - more mailing lists