linux-kernel - Re: [PATCH] kernel/futex: Change pi_state_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 17:06:20 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Xiangyang Yu <yuxiangyang4@...wei.com>, mingo@...hat.com,
        peterz@...radead.org, dvhart@...radead.org
Cc:     linux-kernel@...r.kernel.org, yuxiangyang4@...wei.com
Subject: Re: [PATCH] kernel/futex: Change pi_state_update_owner() to an inline function

On Tue, Mar 09 2021 at 10:40, Xiangyang Yu wrote:
> In our performance tests, we find that the performance of
> sysbench is descend. Function call consumes too many instructions,
> change pi_state_update_owner() to an inline function.

Serioulsy? sysbench does not use PI futexes which means that it does not
ever invoke this function. So it's completely irrelevant for that test
whether the function is marked inline or not.

Aside of that the compiler can ignore 'inline' or inline a static
function. But even if there would be an extra call, then

> Test case: https://github.com/akopytov/sysbench
> Test cmd: ./sysbench --test=threads --num-threads=$thr
>               --thread-yields=100 --thread-locks=2 run
>
> $thr    stock   non-inline   inline
> 256    0.8511     0.9254     0.8588
> 512    0.8489     0.9232     0.8503
> 1024   0.8347     0.9248     0.8495
> 2048   0.8338     0.9575     0.8402

a performance change of this magnitude is certainly not the result. I
also have no idea what these numbers actually mean. Nothing in a
sysbench output with the same parameters looks even close.

But whatever the above is, the 'inline' is neither the cause nor the
cure.

Thanks,

        tglx