linux-kernel - Re: [PATCH -next] mfd: Make symbol 'atc260x_i2c_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210311171208.GB892053@BV030612LT>
Date:   Thu, 11 Mar 2021 19:12:08 +0200
From:   Cristian Ciocaltea <cristian.ciocaltea@...il.com>
To:     'Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Manivannan Sadhasivam <mani@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static

On Thu, Mar 11, 2021 at 01:15:07PM +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> The sparse tool complains as follows:
> 
> drivers/mfd/atc260x-i2c.c:45:27: warning:
>  symbol 'atc260x_i2c_of_match' was not declared. Should it be static?
> 
> This symbol is not used outside of atc260x-i2c.c, so this
> commit marks it static.
> 
> Fixes: f7cb7fe34db9 ("mfd: Add MFD driver for ATC260x PMICs")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@...il.com>

Thanks,
Cristi

> ---
>  drivers/mfd/atc260x-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/atc260x-i2c.c b/drivers/mfd/atc260x-i2c.c
> index 362005703367..5855efd09efc 100644
> --- a/drivers/mfd/atc260x-i2c.c
> +++ b/drivers/mfd/atc260x-i2c.c
> @@ -42,7 +42,7 @@ static int atc260x_i2c_probe(struct i2c_client *client,
>  	return atc260x_device_probe(atc260x);
>  }
>  
> -const struct of_device_id atc260x_i2c_of_match[] = {
> +static const struct of_device_id atc260x_i2c_of_match[] = {
>  	{ .compatible = "actions,atc2603c", .data = (void *)ATC2603C },
>  	{ .compatible = "actions,atc2609a", .data = (void *)ATC2609A },
>  	{ }
>