linux-kernel - arch/arm/boot/compressed/atags_to_fdt.c:100:1: warning: the frame size of 1028 bytes is larger than 1024 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 12 Mar 2021 02:56:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>
Subject: arch/arm/boot/compressed/atags_to_fdt.c:100:1: warning: the frame
 size of 1028 bytes is larger than 1024 bytes

Hi Arnd,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a74e6a014c9d4d4161061f770c9b4f98372ac778
commit: 45fe7befe0db5e61cd3c846315f0ac48541e8445 coresight: remove broken __exit annotations
date:   3 months ago
config: arm-randconfig-r013-20210311 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=45fe7befe0db5e61cd3c846315f0ac48541e8445
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 45fe7befe0db5e61cd3c846315f0ac48541e8445
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   arch/arm/boot/compressed/atags_to_fdt.c:128:5: warning: no previous prototype for 'atags_to_fdt' [-Wmissing-prototypes]
     128 | int atags_to_fdt(void *atag_list, void *fdt, int total_space)
         |     ^~~~~~~~~~~~
   arch/arm/boot/compressed/atags_to_fdt.c: In function 'merge_fdt_bootargs':
>> arch/arm/boot/compressed/atags_to_fdt.c:100:1: warning: the frame size of 1028 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     100 | }
         | ^


vim +100 arch/arm/boot/compressed/atags_to_fdt.c

faefd550c45d8d Gregory CLEMENT 2013-05-15   70  
d0f34a11ddab9b Genoud Richard  2012-06-26   71  static void merge_fdt_bootargs(void *fdt, const char *fdt_cmdline)
d0f34a11ddab9b Genoud Richard  2012-06-26   72  {
d0f34a11ddab9b Genoud Richard  2012-06-26   73  	char cmdline[COMMAND_LINE_SIZE];
d0f34a11ddab9b Genoud Richard  2012-06-26   74  	const char *fdt_bootargs;
d0f34a11ddab9b Genoud Richard  2012-06-26   75  	char *ptr = cmdline;
d0f34a11ddab9b Genoud Richard  2012-06-26   76  	int len = 0;
d0f34a11ddab9b Genoud Richard  2012-06-26   77  
d0f34a11ddab9b Genoud Richard  2012-06-26   78  	/* copy the fdt command line into the buffer */
d0f34a11ddab9b Genoud Richard  2012-06-26   79  	fdt_bootargs = getprop(fdt, "/chosen", "bootargs", &len);
d0f34a11ddab9b Genoud Richard  2012-06-26   80  	if (fdt_bootargs)
d0f34a11ddab9b Genoud Richard  2012-06-26   81  		if (len < COMMAND_LINE_SIZE) {
d0f34a11ddab9b Genoud Richard  2012-06-26   82  			memcpy(ptr, fdt_bootargs, len);
d0f34a11ddab9b Genoud Richard  2012-06-26   83  			/* len is the length of the string
d0f34a11ddab9b Genoud Richard  2012-06-26   84  			 * including the NULL terminator */
d0f34a11ddab9b Genoud Richard  2012-06-26   85  			ptr += len - 1;
d0f34a11ddab9b Genoud Richard  2012-06-26   86  		}
d0f34a11ddab9b Genoud Richard  2012-06-26   87  
d0f34a11ddab9b Genoud Richard  2012-06-26   88  	/* and append the ATAG_CMDLINE */
d0f34a11ddab9b Genoud Richard  2012-06-26   89  	if (fdt_cmdline) {
d0f34a11ddab9b Genoud Richard  2012-06-26   90  		len = strlen(fdt_cmdline);
d0f34a11ddab9b Genoud Richard  2012-06-26   91  		if (ptr - cmdline + len + 2 < COMMAND_LINE_SIZE) {
d0f34a11ddab9b Genoud Richard  2012-06-26   92  			*ptr++ = ' ';
d0f34a11ddab9b Genoud Richard  2012-06-26   93  			memcpy(ptr, fdt_cmdline, len);
d0f34a11ddab9b Genoud Richard  2012-06-26   94  			ptr += len;
d0f34a11ddab9b Genoud Richard  2012-06-26   95  		}
d0f34a11ddab9b Genoud Richard  2012-06-26   96  	}
d0f34a11ddab9b Genoud Richard  2012-06-26   97  	*ptr = '\0';
d0f34a11ddab9b Genoud Richard  2012-06-26   98  
d0f34a11ddab9b Genoud Richard  2012-06-26   99  	setprop_string(fdt, "/chosen", "bootargs", cmdline);
d0f34a11ddab9b Genoud Richard  2012-06-26 @100  }
d0f34a11ddab9b Genoud Richard  2012-06-26  101  

:::::: The code at line 100 was first introduced by commit
:::::: d0f34a11ddab9b456e4caf9fc48d8d7e832e0e50 ARM: 7437/1: zImage: Allow DTB command line concatenation with ATAG_CMDLINE

:::::: TO: Genoud Richard <richard.genoud@...il.com>
:::::: CC: Russell King <rmk+kernel@....linux.org.uk>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (27547 bytes)