linux-kernel - Re: [PATCH] hwmon: Switch to using the new API kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 13:38:31 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: Switch to using the new API kobj_to_dev()

On Tue, Feb 23, 2021 at 05:14:27PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/hwmon/hwmon.c:82:60-61: WARNING opportunity for kobj_to_dev()
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/hwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
> index 6c68405..fd47ab4 100644
> --- a/drivers/hwmon/hwmon.c
> +++ b/drivers/hwmon/hwmon.c
> @@ -79,7 +79,7 @@ struct hwmon_thermal_data {
>  static umode_t hwmon_dev_name_is_visible(struct kobject *kobj,
>  					 struct attribute *attr, int n)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  
>  	if (to_hwmon_device(dev)->name == NULL)
>  		return 0;