lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210311214405.GA35866@roeck-us.net>
Date:   Thu, 11 Mar 2021 13:44:05 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rafael@...nel.org, andriy.shevchenko@...ux.intel.com,
        linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        "open list:HARDWARE MONITORING" <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH v2 5/9] hwmon/drivers/mr75203: Use HZ macros

On Wed, Feb 24, 2021 at 03:42:15PM +0100, Daniel Lezcano wrote:
> HZ unit conversion macros are available in units.h, use them and
> remove the duplicate definition.

I assume the idea is to submit the series together, so

Acked-by: Guenter Roeck <linux@...ck-us.net>

Guenter

> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> Reviewed-by: Christian Eggers <ceggers@...i.de>
> ---
>  drivers/hwmon/mr75203.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 18da5a25e89a..868243dba1ee 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -17,6 +17,7 @@
>  #include <linux/property.h>
>  #include <linux/regmap.h>
>  #include <linux/reset.h>
> +#include <linux/units.h>
>  
>  /* PVT Common register */
>  #define PVT_IP_CONFIG	0x04
> @@ -37,7 +38,6 @@
>  #define CLK_SYNTH_EN		BIT(24)
>  #define CLK_SYS_CYCLES_MAX	514
>  #define CLK_SYS_CYCLES_MIN	2
> -#define HZ_PER_MHZ		1000000L
>  
>  #define SDIF_DISABLE	0x04
>  

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ