[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210311215055.GA36492@roeck-us.net>
Date: Thu, 11 Mar 2021 13:50:55 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Jiqi Li <lijq9@...ovo.com>
Cc: jdelvare@...e.com, linux-hwmon@...r.kernel.org,
linux-kernel@...r.kernel.org, markpearson@...ovo.com
Subject: Re: [PATCH v2] hwmon: (nct6883) Support NCT6686D
On Thu, Mar 04, 2021 at 06:44:21PM +0800, Jiqi Li wrote:
> Add support for NCT6686D chip used in the Lenovo P620.
>
> Signed-off-by: Jiqi Li <lijq9@...ovo.com>
> Reviewed-by: Mark Pearson <markpearson@...ovo.com>
> ---
> Changes in v2: Corrected typo from NCT6886D to NCT6686D
Not entirely; the subject is still partially wrong.
No need to resend, though, I'll fix then while applying it.
Guenter
> ---
> drivers/hwmon/nct6683.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index a23047a3bfe2..256e8d62f858 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * nct6683 - Driver for the hardware monitoring functionality of
> - * Nuvoton NCT6683D/NCT6687D eSIO
> + * Nuvoton NCT6683D/NCT6686D/NCT6687D eSIO
> *
> * Copyright (C) 2013 Guenter Roeck <linux@...ck-us.net>
> *
> @@ -12,6 +12,7 @@
> *
> * Chip #vin #fan #pwm #temp chip ID
> * nct6683d 21(1) 16 8 32(1) 0xc730
> + * nct6686d 21(1) 16 8 32(1) 0xd440
> * nct6687d 21(1) 16 8 32(1) 0xd590
> *
> * Notes:
> @@ -33,7 +34,7 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
>
> -enum kinds { nct6683, nct6687 };
> +enum kinds { nct6683, nct6686, nct6687 };
>
> static bool force;
> module_param(force, bool, 0);
> @@ -41,11 +42,13 @@ MODULE_PARM_DESC(force, "Set to one to enable support for unknown vendors");
>
> static const char * const nct6683_device_names[] = {
> "nct6683",
> + "nct6686",
> "nct6687",
> };
>
> static const char * const nct6683_chip_names[] = {
> "NCT6683D",
> + "NCT6686D",
> "NCT6687D",
> };
>
> @@ -66,6 +69,7 @@ static const char * const nct6683_chip_names[] = {
>
> #define SIO_NCT6681_ID 0xb270 /* for later */
> #define SIO_NCT6683_ID 0xc730
> +#define SIO_NCT6686_ID 0xd440
> #define SIO_NCT6687_ID 0xd590
> #define SIO_ID_MASK 0xFFF0
>
> @@ -1362,6 +1366,9 @@ static int __init nct6683_find(int sioaddr, struct nct6683_sio_data *sio_data)
> case SIO_NCT6683_ID:
> sio_data->kind = nct6683;
> break;
> + case SIO_NCT6686_ID:
> + sio_data->kind = nct6686;
> + break;
> case SIO_NCT6687_ID:
> sio_data->kind = nct6687;
> break;
Powered by blists - more mailing lists