| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d44708530dd0ef1d758dee6651779679a22c3dff.camel@nxp.com>
Date: Thu, 11 Mar 2021 13:26:51 +0800
From: Liu Ying <victor.liu@....com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, airlied@...ux.ie, daniel@...ll.ch,
robh+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
mchehab@...nel.org, a.hajda@...sung.com, narmstrong@...libre.com,
jonas@...boo.se, jernej.skrabec@...l.net, kishon@...com,
vkoul@...nel.org, robert.foss@...aro.org, lee.jones@...aro.org
Subject: Re: [PATCH v5 02/14] media: docs: Add some RGB bus formats for
i.MX8qm/qxp pixel combiner
Hi Laurent,
On Wed, 2021-03-10 at 15:24 +0200, Laurent Pinchart wrote:
> Hi Liu,
>
> Thank you for the patch.
Thanks for your review.
>
> On Wed, Mar 10, 2021 at 05:55:26PM +0800, Liu Ying wrote:
> > This patch adds documentations for RGB666_1X30_CPADLO, RGB888_1X30_CPADLO,
> > RGB666_1X36_CPADLO and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp
> > pixel combiner. The RGB pixels with padding low per component are
> > transmitted on a 30-bit input bus(10-bit per component) from a display
> > controller or a 36-bit output bus(12-bit per component) to a pixel link.
> >
> > Reviewed-by: Robert Foss <robert.foss@...aro.org>
> > Signed-off-by: Liu Ying <victor.liu@....com>
> > ---
> > v4->v5:
> > * Add Robert's R-b tag.
> >
> > v3->v4:
> > * No change.
> >
> > v2->v3:
> > * No change.
> >
> > v1->v2:
> > * No change.
> >
> > .../userspace-api/media/v4l/subdev-formats.rst | 156 +++++++++++++++++++++
> > 1 file changed, 156 insertions(+)
> >
> > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > index 7f16cbe..201c16d 100644
> > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > @@ -1488,6 +1488,80 @@ The following tables list existing packed RGB formats.
> > - b\ :sub:`2`
> > - b\ :sub:`1`
> > - b\ :sub:`0`
> > + * .. _MEDIA-BUS-FMT-RGB666-1X30-CPADLO:
> > +
> > + - MEDIA_BUS_FMT_RGB666_1X30-CPADLO
> > + - 0x101e
> > + -
> > + - 0
> > + - 0
>
> I count 32 bits here. Should these two 0 be replaced by spaces ? Same
> for MEDIA_BUS_FMT_RGB888_1X30-CPADLO.
Indeed, these two 0 should be spaces. Will fix them in next version.
I see the in-tree MEDIA_BUS_FMT_RGB101010_1X30 has the same issue.
I can send another patch to fix it.
Regards,
Liu Ying
>
> With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>
> > + - r\ :sub:`5`
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - b\ :sub:`5`
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + * .. _MEDIA-BUS-FMT-RGB888-1X30-CPADLO:
> > +
> > + - MEDIA_BUS_FMT_RGB888_1X30-CPADLO
> > + - 0x101f
> > + -
> > + - 0
> > + - 0
> > + - r\ :sub:`7`
> > + - r\ :sub:`6`
> > + - r\ :sub:`5`
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - g\ :sub:`7`
> > + - g\ :sub:`6`
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - b\ :sub:`7`
> > + - b\ :sub:`6`
> > + - b\ :sub:`5`
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > + - 0
> > + - 0
> > * .. _MEDIA-BUS-FMT-ARGB888-1X32:
> >
> > - MEDIA_BUS_FMT_ARGB888_1X32
> > @@ -1665,6 +1739,88 @@ The following table list existing packed 36bit wide RGB formats.
> > - 2
> > - 1
> > - 0
> > + * .. _MEDIA-BUS-FMT-RGB666-1X36-CPADLO:
> > +
> > + - MEDIA_BUS_FMT_RGB666_1X36_CPADLO
> > + - 0x1020
> > + -
> > + - r\ :sub:`5`
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - b\ :sub:`5`
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + * .. _MEDIA-BUS-FMT-RGB888-1X36-CPADLO:
> > +
> > + - MEDIA_BUS_FMT_RGB888_1X36_CPADLO
> > + - 0x1021
> > + -
> > + - r\ :sub:`7`
> > + - r\ :sub:`6`
> > + - r\ :sub:`5`
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - g\ :sub:`7`
> > + - g\ :sub:`6`
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - b\ :sub:`7`
> > + - b\ :sub:`6`
> > + - b\ :sub:`5`
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > * .. _MEDIA-BUS-FMT-RGB121212-1X36:
> >
> > - MEDIA_BUS_FMT_RGB121212_1X36
Powered by blists - more mailing lists