linux-kernel - Re: [PATCH v2] configfs: Fix config_item refcnt error in __configfs_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YEoCRFiDTool4g3Z@kroah.com>
Date:   Thu, 11 Mar 2021 12:43:00 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Joel Becker <jlbec@...lplan.org>, linux-kernel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>,
        Daniel Rosenberg <drosen@...gle.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] configfs: Fix config_item refcnt error in
 __configfs_open_file()

On Thu, Mar 11, 2021 at 12:39:40PM +0100, Christoph Hellwig wrote:
> On Thu, Mar 11, 2021 at 12:35:10PM +0100, gregkh@...uxfoundation.org wrote:
> > From: Daniel Rosenberg <drosen@...gle.com>
> > 
> > __configfs_open_file() used to use configfs_get_config_item, but changed
> > in commit b0841eefd969 ("configfs: provide exclusion between IO and
> > removals") to just call to_item. The error path still tries to clean up
> > the reference, incorrectly decrementing the ref count.
> 
> This should already be covered by:
> 
> http://git.infradead.org/users/hch/configfs.git/commitdiff/14fbbc8297728e880070f7b077b3301a8c698ef9

Yup, identical patch, sorry I missed that one, hopefully it hits Linus's
tree soon.

thanks,

greg k-h