[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210311121923.GU3479805@casper.infradead.org>
Date: Thu, 11 Mar 2021 12:19:23 +0000
From: Matthew Wilcox <willy@...radead.org>
To: "chenjun (AM)" <chenjun102@...wei.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
Dan Williams <dan.j.williams@...el.com>,
Jan Kara <jack@...e.cz>,
"Xiangrui (Euler)" <rui.xiang@...wei.com>,
"lizhe (Y)" <lizhe67@...wei.com>, yangerkun <yangerkun@...wei.com>,
"zhangyi (F)" <yi.zhang@...wei.com>
Subject: Re: [question] Panic in dax_writeback_one
On Thu, Mar 11, 2021 at 07:48:25AM +0000, chenjun (AM) wrote:
> static int dax_writeback_one(struct xa_state *xas, struct dax_device
> *dax_dev, struct address_space *mapping, void *entry)
> ----dax_flush(dax_dev, page_address(pfn_to_page(pfn)), count * PAGE_SIZE);
> The pfn is returned by the driver. In my case, the pfn does not have
> struct page. so pfn_to_page(pfn) return a wrong address.
I wasn't involved, but I think the right solution here is simply to
replace page_address(pfn_to_page(pfn)) with pfn_to_virt(pfn). I don't
know why Dan decided to do this in the more complicated way.
Powered by blists - more mailing lists