linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 06:56:34 -0600
From:   Nishanth Menon <nm@...com>
To:     "Bajjuri, Praneeth" <praneeth@...com>
CC:     Jan Kiszka <jan.kiszka@....de>, Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry

On 19:36-20210310, Bajjuri, Praneeth wrote:
> 
> 
> On 2/20/2021 6:49 AM, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@...mens.com>
> > 
> > Add the DT entry for a watchdog based on RTI1.
> > 
> > On SR1.0 silicon, it requires additional firmware on the MCU R5F cores
> > to handle the expiry, e.g. https://github.com/siemens/k3-rti-wdt. As
> > this firmware will also lock the power domain to protect it against
> > premature shutdown, mark it shared.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> 
> Acked-by: Praneeth Bajjuri <praneeth@...com>
> 
> > ---
> >   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > index 7454c8cec0cc..903796bf7d64 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > @@ -308,4 +308,13 @@ mcu_r5fss0_core1: r5f@...00000 {
> >   			ti,loczrama = <1>;
> >   		};
> >   	};
> > +
> > +	mcu_rti1: rti@...10000 {

Jan, I was about to pick up the patches and was running through
my sanity checks and the following caught my eye with dtbs_check
(dtschema is at 2021.2.1) test against next-20210311

/workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: rti@...10000: $nodename:0: 'rti@...10000' does not match '^watchdog(@.*|-[0-9a-f])?$'

Please use watchdog@...10000 instead of rti@...10000

Since this is a minor change, I have done this change locally. let me
know if you have an issue and I can drop it off my branch for a new
version.

[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D