linux-kernel - Re: [PATCH v4 3/3] arm64: dts: ti: Add support for Siemens IOT2050 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210311131754.i5ewls6hgeitcgre@astonish>
Date:   Thu, 11 Mar 2021 07:17:54 -0600
From:   Nishanth Menon <nm@...com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
CC:     Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        Le Jin <le.jin@...mens.com>,
        Bao Cheng Su <baocheng.su@...mens.com>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v4 3/3] arm64: dts: ti: Add support for Siemens IOT2050
 boards

On 10:37-20210310, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@...mens.com>
> +	spidev@0 {
> +		compatible = "rohm,dh2228fv";
> +		spi-max-frequency = <20000000>;
> +		reg = <0>;

Jan,

As part of my final sanity checks, I noticed that we missed this: is a checkpatch warning

WARNING: DT compatible string "rohm,dh2228fv" appears un-documented -- check ./Documentation/devicetree/bindings/
#629: FILE: arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi:581:
		compatible = "rohm,dh2228fv";

I cannot pick up nodes that are'nt documented as yaml in
	Documentation/devicetree

I know this is irritating to find such nodes that already have previous
users and the person coming last gets to deal with "new rules".. but
sorry for catching this so late.

Here are the options that come to mind:

option 1) - drop the node and resubmit.

option 2) - get the documentation into linux master tree and then submit
the patches.


I think we should just drop the node and resubmit - since this is a more
intrusive change and I don't have your platform handy, I am going to
suggest you make a call :(

Additionally please install yamlint and dtbs_schema -> run dtbs_check. I
see more than a few warnings there which may need some closer look.


A full log against linux-next is here: https://pastebin.ubuntu.com/p/qR69h28c5f/


PS: https://github.com/nmenon/kernel_patch_verify/blob/master/kpv

I have been using my script to verify with kpv -C -V -n num_patches and
then digging through the logs.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D