linux-kernel - Re: [PATCH v1 1/1] ALSA: hda/realtek: Sort alphanumerically the SND_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hmtv9vl7n.wl-tiwai@suse.de>
Date:   Thu, 11 Mar 2021 15:06:20 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v1 1/1] ALSA: hda/realtek: Sort alphanumerically the SND_PCI_QUIRK() entries.

On Thu, 11 Mar 2021 15:02:16 +0100,
Andy Shevchenko wrote:
> 
> On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai <tiwai@...e.de> wrote:
> >
> > On Thu, 11 Mar 2021 14:27:41 +0100,
> > Andy Shevchenko wrote:
> > >
> > > Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
> > > No functional change implied.
> >
> > I'd love to apply this kind of cleanups (and I do sometimes
> > partially), but practically seen, this may make the stable backporting
> > significantly harder because many quirk patches are backported to the
> > very old LTS kernels.  So, unless any specific reason (e.g. some
> > entries doubled or wrongly applied) is given, I'd avoid this full
> > plastic surgery.
> 
> Can we ask people to follow the ordering before patches were applied?

Yeah, I should apply more strict check in my side in future, too.


Takashi