linux-kernel - Re: [PATCH] leds: leds-dual-gpio: Add dual GPIO LEDs driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210311163951.0046fb5c@nic.cz>
Date:   Thu, 11 Mar 2021 16:39:51 +0100
From:   Marek Behun <marek.behun@....cz>
To:     Hermes Zhang <chenhui.zhang@...s.com>
Cc:     Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        <kernel@...s.com>, Hermes Zhang <chenhuiz@...s.com>,
        <linux-kernel@...r.kernel.org>, <linux-leds@...r.kernel.org>
Subject: Re: [PATCH] leds: leds-dual-gpio: Add dual GPIO LEDs driver

On Thu, 11 Mar 2021 16:38:14 +0100
Marek Behun <marek.behun@....cz> wrote:

> LED_FULL, LED_HALF, LED_OFF are deprecated.
> 
> And this driver is redundant. This can be done with leds-regulator,
> with a gpio-regulator.
> 
> Marek

Sorry, leds-regulator has only a binary state LED.

Maybe you could extend leds-regulator to be able to use all regulator
states?

Or you can extend leds-gpio driver to support N states via log N
gpios, instead of adding new driver.

Marek