linux-kernel - Re: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4609846ceedc24505dcaaba40933abb8b3e577e1.camel@linux.intel.com>
Date:   Fri, 12 Mar 2021 07:30:48 -0800
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Antonio Terceiro <antonio.terceiro@...aro.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and
 __TIME__ macros

On Fri, 2021-03-12 at 10:57 -0300, Antonio Terceiro wrote:
> These macros introduce nondeterminism in builds, and break
> reproducible
> builds.

Thanks. I will include this change in my pull request.

-Srinivas

> 
> Signed-off-by: Antonio Terceiro <antonio.terceiro@...aro.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> ---
>  tools/power/x86/intel-speed-select/isst-config.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> b/tools/power/x86/intel-speed-select/isst-config.c
> index 582feb88eca3..c50c754a656e 100644
> --- a/tools/power/x86/intel-speed-select/isst-config.c
> +++ b/tools/power/x86/intel-speed-select/isst-config.c
> @@ -2791,7 +2791,6 @@ static void usage(void)
>  static void print_version(void)
>  {
>  	fprintf(outf, "Version %s\n", version_str);
> -	fprintf(outf, "Build date %s time %s\n", __DATE__, __TIME__);
>  	exit(0);
>  }
>