[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALvZod4vmZztdbjkWT8soRd3P=JXyNJChDTOUP1HaiSQhKoutw@mail.gmail.com>
Date: Thu, 11 Mar 2021 19:22:20 -0800
From: Shakeel Butt <shakeelb@...gle.com>
To: Muchun Song <songmuchun@...edance.com>
Cc: Roman Gushchin <guro@...com>, Johannes Weiner <hannes@...xchg.org>,
Michal Hocko <mhocko@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Vladimir Davydov <vdavydov.dev@...il.com>,
LKML <linux-kernel@...r.kernel.org>,
Linux MM <linux-mm@...ck.org>,
Xiongchun duan <duanxiongchun@...edance.com>
Subject: Re: [PATCH v3 2/4] mm: memcontrol: make page_memcg{_rcu} only
applicable for non-kmem page
On Tue, Mar 9, 2021 at 2:09 AM Muchun Song <songmuchun@...edance.com> wrote:
>
> We want to reuse the obj_cgroup APIs to charge the kmem pages.
> If we do that, we should store an object cgroup pointer to
> page->memcg_data for the kmem pages.
>
> Finally, page->memcg_data can have 3 different meanings.
replace 'can' with 'will'
Other than that I think Roman and Johannes have already given very
good feedback.
Powered by blists - more mailing lists