linux-kernel - Re: [PATCH] kvm: x86: annotate RCU pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7ba3b977-d6a3-3518-7426-42e36ec546fc@redhat.com>
Date:   Fri, 12 Mar 2021 19:17:47 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Muhammad Usama Anjum <musamaanjum@...il.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: x86: annotate RCU pointers

On 05/03/21 20:11, Muhammad Usama Anjum wrote:
> This patch adds the annotation to fix the following sparse errors:
> arch/x86/kvm//x86.c:8147:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//x86.c:8147:15:    struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//x86.c:8147:15:    struct kvm_apic_map *
> arch/x86/kvm//x86.c:10628:16: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//x86.c:10628:16:    struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//x86.c:10628:16:    struct kvm_apic_map *
> arch/x86/kvm//x86.c:10629:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//x86.c:10629:15:    struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//x86.c:10629:15:    struct kvm_pmu_event_filter *
> arch/x86/kvm//lapic.c:267:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:267:15:    struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:267:15:    struct kvm_apic_map *
> arch/x86/kvm//lapic.c:269:9: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:269:9:    struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:269:9:    struct kvm_apic_map *
> arch/x86/kvm//lapic.c:637:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:637:15:    struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:637:15:    struct kvm_apic_map *
> arch/x86/kvm//lapic.c:994:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:994:15:    struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:994:15:    struct kvm_apic_map *
> arch/x86/kvm//lapic.c:1036:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:1036:15:    struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:1036:15:    struct kvm_apic_map *
> arch/x86/kvm//lapic.c:1173:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:1173:15:    struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:1173:15:    struct kvm_apic_map *
> arch/x86/kvm//pmu.c:190:18: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//pmu.c:190:18:    struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//pmu.c:190:18:    struct kvm_pmu_event_filter *
> arch/x86/kvm//pmu.c:251:18: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//pmu.c:251:18:    struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//pmu.c:251:18:    struct kvm_pmu_event_filter *
> arch/x86/kvm//pmu.c:522:18: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//pmu.c:522:18:    struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//pmu.c:522:18:    struct kvm_pmu_event_filter *
> arch/x86/kvm//pmu.c:522:18: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//pmu.c:522:18:    struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//pmu.c:522:18:    struct kvm_pmu_event_filter *
> 
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@...il.com>
> ---
>   arch/x86/include/asm/kvm_host.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 84499aad01a4..ad675c8c05e7 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -958,7 +958,7 @@ struct kvm_arch {
>   	struct kvm_pit *vpit;
>   	atomic_t vapics_in_nmi_mode;
>   	struct mutex apic_map_lock;
> -	struct kvm_apic_map *apic_map;
> +	struct kvm_apic_map __rcu *apic_map;
>   	atomic_t apic_map_dirty;
>   
>   	bool apic_access_page_done;
> @@ -1030,7 +1030,7 @@ struct kvm_arch {
>   
>   	bool bus_lock_detection_enabled;
>   
> -	struct kvm_pmu_event_filter *pmu_event_filter;
> +	struct kvm_pmu_event_filter __rcu *pmu_event_filter;
>   	struct task_struct *nx_lpage_recovery_thread;
>   
>   #ifdef CONFIG_X86_64
> 

Queued, thanks.

Paolo