linux-kernel - Re: [PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ACD7D8F0-345B-4A4B-8F39-64CA119B5501@amd.com>
Date:   Fri, 12 Mar 2021 22:28:33 +0000
From:   "Zeng, Oak" <Oak.Zeng@....com>
To:     Souptick Joarder <jrdr.linux@...il.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "Zhang, Hawking" <Hawking.Zhang@....com>,
        "Kuehling, Felix" <Felix.Kuehling@....com>,
        "Wang, Kevin(Yang)" <Kevin1.Wang@....com>,
        "Ma, Le" <Le.Ma@....com>, "Lazar, Lijo" <Lijo.Lazar@....com>
CC:     "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt_regs() as static

[AMD Official Use Only - Internal Distribution Only]

Thank you Joarder for the fix. But this has already been fixed in our Alex's drm-next branch.

Regards,
Oak



On 2021-03-12, 5:19 PM, "Souptick Joarder" <jrdr.linux@...il.com> wrote:

    Kernel test robot throws below warning ->

    drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c:56:6: warning: no previous
    prototype for 'mmhub_v1_7_setup_vm_pt_regs' [-Wmissing-prototypes]

    Mark mmhub_v1_7_setup_vm_pt_regs() as static.

    Reported-by: kernel test robot <lkp@...el.com>
    Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
    ---
     drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
    index 4df0b73..ae7d8a1 100644
    --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
    +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
    @@ -53,7 +53,7 @@ static u64 mmhub_v1_7_get_fb_location(struct amdgpu_device *adev)
     return base;
     }

    -void mmhub_v1_7_setup_vm_pt_regs(struct amdgpu_device *adev, uint32_t vmid,
    +static void mmhub_v1_7_setup_vm_pt_regs(struct amdgpu_device *adev, uint32_t vmid,
     uint64_t page_table_base)
     {
     struct amdgpu_vmhub *hub = &adev->vmhub[AMDGPU_MMHUB_0];
    --
    1.9.1