linux-kernel - Re: [PATCH] net: ethernet: dec: tulip: Random spelling fixes throughout the file pnic2.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe57b506-b737-e3a5-025f-a9cad45a1dca@infradead.org>
Date:   Thu, 11 Mar 2021 23:23:05 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: dec: tulip: Random spelling fixes
 throughout the file pnic2.c

On 3/11/21 11:05 PM, Bhaskar Chowdhury wrote:
> 
> Random spelling fixes throughout the file.
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> ---
>  drivers/net/ethernet/dec/tulip/pnic2.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/dec/tulip/pnic2.c b/drivers/net/ethernet/dec/tulip/pnic2.c
> index 412adaa7fdf8..04daffb8db2a 100644
> --- a/drivers/net/ethernet/dec/tulip/pnic2.c
> +++ b/drivers/net/ethernet/dec/tulip/pnic2.c
> @@ -107,7 +107,7 @@ void pnic2_start_nway(struct net_device *dev)
>           */
>  	csr14 = (ioread32(ioaddr + CSR14) & 0xfff0ee39);
> 
> -        /* bit 17 - advetise 100baseTx-FD */
> +        /* bit 17 - advertise 100baseTx-FD */

OK above. But:
https://en.wikipedia.org/wiki/Autonegotiation

>          if (tp->sym_advertise & 0x0100) csr14 |= 0x00020000;
> 
>          /* bit 16 - advertise 100baseTx-HD */
> @@ -116,7 +116,7 @@ void pnic2_start_nway(struct net_device *dev)
>          /* bit 6 - advertise 10baseT-HD */
>          if (tp->sym_advertise & 0x0020) csr14 |= 0x00000040;
> 
> -        /* Now set bit 12 Link Test Enable, Bit 7 Autonegotiation Enable
> +        /* Now set bit 12 Link Test Enable, Bit 7 Auto negotiation Enable
>           * and bit 0 Don't PowerDown 10baseT
>           */
>          csr14 |= 0x00001184;
> @@ -157,7 +157,7 @@ void pnic2_start_nway(struct net_device *dev)
>          /* all set up so now force the negotiation to begin */
> 
>          /* read in current values and mask off all but the
> -	 * Autonegotiation bits 14:12.  Writing a 001 to those bits
> +	 * Auto negotiation bits 14:12.  Writing a 001 to those bits
>           * should start the autonegotiation
>           */
>          csr12 = (ioread32(ioaddr + CSR12) & 0xffff8fff);
> @@ -290,7 +290,7 @@ void pnic2_lnk_change(struct net_device *dev, int csr5)
>  	                csr14 = (ioread32(ioaddr + CSR14) & 0xffffff7f);
>                          iowrite32(csr14,ioaddr + CSR14);
> 
> -                        /* what should we do when autonegotiate fails?
> +                        /* what should we do when auto negotiate fails?
>                           * should we try again or default to baseline
>                           * case.  I just don't know.
>                           *
> --


-- 
~Randy