linux-kernel - Re: [PATCH v3 08/11] gpio: sim: new testing module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Mar 2021 13:03:51 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Joel Becker <jlbec@...lplan.org>, Christoph Hellwig <hch@....de>,
        Shuah Khan <shuah@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Kent Gibson <warthog618@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-doc <linux-doc@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v3 08/11] gpio: sim: new testing module

On Fri, Mar 12, 2021 at 09:54:58AM +0100, Bartosz Golaszewski wrote:
> On Wed, Mar 10, 2021 at 1:28 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

...

> > > +             ret = sprintf(page, "n/a\n");
> >
> > I dunno '/' (slash) is a good character to be handled in a shell.
> > I would prefer 'none' or 'not available' (I think space is easier,
> > because the rules to escape much simpler: need just to take it into
> > quotes, while / needs to be escaped separately).
> >
> 
> My test cases work fine with 'n/a' but I can change it to 'none' if
> it's less controversial.


% git grep -n -w '"none"' -- drivers/ arch/ | wc -l
371

% git grep -n -w '"n/a"' -- drivers/ arch/ | wc -l
15

% git grep -n -w '"not available"' -- drivers/ arch/ | wc -l
5

...

> But I would be creating empty properties for nothing. Better to just
> not have them at all.

Up to you.

-- 
With Best Regards,
Andy Shevchenko