linux-kernel - Re: [PATCH 3/3] thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Mar 2021 11:34:36 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rui.zhang@...el.com, amitk@...nel.org, linux-pm@...r.kernel.org,
        Amit Daniel Kachhap <amit.kachhap@...il.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Javi Merino <javi.merino@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] thermal/drivers/cpuidle_cooling: Use device name
 instead of auto-numbering



On 3/10/21 11:46 AM, Daniel Lezcano wrote:
> Currently the naming of a cooling device is just a cooling technique
> followed by a number. When there are multiple cooling devices using
> the same technique, it is impossible to clearly identify the related
> device as this one is just a number.
> 
> For instance:
> 
>   thermal-idle-0
>   thermal-idle-1
>   thermal-idle-2
>   thermal-idle-3
>   etc ...
> 
> The 'thermal' prefix is redundant with the subsystem namespace. This
> patch removes the 'thermal prefix and changes the number by the device

missing ' after 'thermal

> name. So the naming above becomes:
> 
>   idle-cpu0
>   idle-cpu1
>   idle-cpu2
>   idle-cpu3
>   etc ...
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>   drivers/thermal/cpuidle_cooling.c | 26 ++++++++++----------------
>   1 file changed, 10 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
> index 7ecab4b16b29..8bc0a9b46358 100644
> --- a/drivers/thermal/cpuidle_cooling.c
> +++ b/drivers/thermal/cpuidle_cooling.c
> @@ -9,6 +9,7 @@
>   
>   #include <linux/cpu_cooling.h>
>   #include <linux/cpuidle.h>
> +#include <linux/device.h>
>   #include <linux/err.h>
>   #include <linux/idle_inject.h>
>   #include <linux/idr.h>

idr.h not needed any more


other than that LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@....com>