linux-kernel - Re: [PATCH] crypto: ccp - Don't initialize SEV support without the SEV feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210312131248.GG31502@gondor.apana.org.au>
Date:   Sat, 13 Mar 2021 00:12:48 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Tom Lendacky <thomas.lendacky@....com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        John Allen <john.allen@....com>,
        Brijesh Singh <brijesh.singh@....com>
Subject: Re: [PATCH] crypto: ccp - Don't initialize SEV support without the
 SEV feature

On Wed, Mar 03, 2021 at 04:31:09PM -0600, Tom Lendacky wrote:
> From: Tom Lendacky <thomas.lendacky@....com>
> 
> If SEV has been disabled (e.g. through BIOS), the driver probe will still
> issue SEV firmware commands. The SEV INIT firmware command will return an
> error in this situation, but the error code is a general error code that
> doesn't highlight the exact reason.
> 
> Add a check for X86_FEATURE_SEV in sev_dev_init() and emit a meaningful
> message and skip attempting to initialize the SEV firmware if the feature
> is not enabled. Since building the SEV code is dependent on X86_64, adding
> the check won't cause any build problems.
> 
> Cc: John Allen <john.allen@....com>
> Cc: Brijesh Singh <brijesh.singh@....com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>
> ---
>  drivers/crypto/ccp/sev-dev.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt