linux-kernel - Re: [PATCH] ALSA: sb: Remove extra brackets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5heegktsxh.wl-tiwai@suse.de>
Date:   Fri, 12 Mar 2021 14:14:50 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     tiwai@...e.com, perex@...ex.cz, joe@...ches.com, jgg@...pe.ca,
        chao@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: sb: Remove extra brackets

On Fri, 12 Mar 2021 10:36:25 +0100,
Xu Wang wrote:
> 
> Remove extra brackets.
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>

Thanks for the patch.  But this kind of change alone makes little
benefit, as it doesn't improve the readability significantly.
So I'd take such a change only if it's really needed, e.g. if it's a
preliminary work for the further real fixes.


Takashi


> ---
>  sound/isa/sb/sb16_csp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/isa/sb/sb16_csp.c b/sound/isa/sb/sb16_csp.c
> index 8635a2b6b36b..2c292bf0f5ae 100644
> --- a/sound/isa/sb/sb16_csp.c
> +++ b/sound/isa/sb/sb16_csp.c
> @@ -769,7 +769,7 @@ static int snd_sb_csp_autoload(struct snd_sb_csp * p, snd_pcm_format_t pcm_sfmt,
>  
>  			p->running = 0;				/* clear autoloaded flag */
>  			p->mode = 0;
> -			return (err);
> +			return err;
>  		} else {
>  			p->running = SNDRV_SB_CSP_ST_AUTO;	/* set autoloaded flag */
>  			p->acc_width = SNDRV_SB_CSP_SAMPLE_16BIT;	/* only 16 bit data */
> -- 
> 2.17.1
>