linux-kernel - Re: [v4] PCI: Add reset quirk for Huawei Intelligent NIC virtual function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 13 Mar 2021 17:28:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chiqijun <chiqijun@...wei.com>, bhelgaas@...gle.com
Cc:     kbuild-all@...ts.01.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, alex.williamson@...hat.com,
        yin.yinshi@...wei.com, cloud.wangxiaoyun@...wei.com,
        zengweiliang.zengweiliang@...wei.com, chenlizhong@...wei.com
Subject: Re: [v4] PCI: Add reset quirk for Huawei Intelligent NIC virtual
 function

Hi Chiqijun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[also build test WARNING on v5.12-rc2 next-20210312]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chiqijun/PCI-Add-reset-quirk-for-Huawei-Intelligent-NIC-virtual-function/20210313-152632
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: sparc-randconfig-s031-20210313 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-262-g5e674421-dirty
        # https://github.com/0day-ci/linux/commit/2ee50cef940514cc4b80bf8d550cb4f28e257d7a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chiqijun/PCI-Add-reset-quirk-for-Huawei-Intelligent-NIC-virtual-function/20210313-152632
        git checkout 2ee50cef940514cc4b80bf8d550cb4f28e257d7a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


"sparse warnings: (new ones prefixed by >>)"
   drivers/pci/quirks.c:2287:57: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/quirks.c:3938:15: sparse: sparse: cast to restricted __be32
   drivers/pci/quirks.c:3948:15: sparse: sparse: cast to restricted __be32
>> drivers/pci/quirks.c:3950:16: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected unsigned int [usertype] l @@     got restricted __be32 [usertype] @@
   drivers/pci/quirks.c:3950:16: sparse:     expected unsigned int [usertype] l
   drivers/pci/quirks.c:3950:16: sparse:     got restricted __be32 [usertype]
   drivers/pci/quirks.c:3965:23: sparse: sparse: cast to restricted __be32
   drivers/pci/quirks.c:3971:15: sparse: sparse: cast to restricted __be32

vim +3950 drivers/pci/quirks.c

  3922	
  3923	/* Device-specific reset method for Huawei Intelligent NIC virtual functions */
  3924	static int reset_hinic_vf_dev(struct pci_dev *pdev, int probe)
  3925	{
  3926		unsigned long timeout;
  3927		void __iomem *bar;
  3928		u32 val;
  3929	
  3930		if (probe)
  3931			return 0;
  3932	
  3933		bar = pci_iomap(pdev, 0, 0);
  3934		if (!bar)
  3935			return -ENOTTY;
  3936	
  3937		/* Get and check firmware capabilities. */
  3938		val = be32_to_cpu(readl(bar + HINIC_VF_FLR_TYPE));
  3939		if (!(val & (1UL << HINIC_VF_FLR_CAP_BIT_SHIFT))) {
  3940			pci_iounmap(pdev, bar);
  3941			return -ENOTTY;
  3942		}
  3943	
  3944		/*
  3945		 * Set the processing bit for the start of FLR, which will be cleared
  3946		 * by the firmware after FLR is completed.
  3947		 */
  3948		val = be32_to_cpu(readl(bar + HINIC_VF_OP));
  3949		val = val | (1UL << HINIC_VF_FLR_PROC_BIT_SHIFT);
> 3950		writel(cpu_to_be32(val), bar + HINIC_VF_OP);
  3951	
  3952		/* Perform the actual device function reset */
  3953		pcie_flr(pdev);
  3954	
  3955		/*
  3956		 * The device must learn BDF after FLR in order to respond to BAR's
  3957		 * read request, therefore, we issue a configure write request to let
  3958		 * the device capture BDF.
  3959		 */
  3960		pci_write_config_word(pdev, PCI_VENDOR_ID, 0);
  3961	
  3962		/* Waiting for device reset complete */
  3963		timeout = jiffies + msecs_to_jiffies(HINIC_OPERATION_TIMEOUT);
  3964		do {
  3965			val = be32_to_cpu(readl(bar + HINIC_VF_OP));
  3966			if (!(val & (1UL << HINIC_VF_FLR_PROC_BIT_SHIFT)))
  3967				goto reset_complete;
  3968			msleep(20);
  3969		} while (time_before(jiffies, timeout));
  3970	
  3971		val = be32_to_cpu(readl(bar + HINIC_VF_OP));
  3972		if (!(val & (1UL << HINIC_VF_FLR_PROC_BIT_SHIFT)))
  3973			goto reset_complete;
  3974	
  3975		pci_warn(pdev, "Reset dev timeout, flr ack reg: %#010x\n", val);
  3976	
  3977	reset_complete:
  3978		pci_iounmap(pdev, bar);
  3979	
  3980		return 0;
  3981	}
  3982	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25836 bytes)