linux-kernel - Re: [PATCH] mm/huge_memory.c: use helper function migration_entry_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Mar 2021 18:36:13 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     <akpm@...ux-foundation.org>
CC:     <ziy@...dia.com>, <willy@...radead.org>,
        <william.kucharski@...cle.com>, <vbabka@...e.cz>,
        <richard.weiyang@...ux.alibaba.com>, <peterx@...hat.com>,
        <anshuman.khandual@....com>, <thomas_os@...pmail.org>,
        <rcampbell@...dia.com>, <aneesh.kumar@...ux.ibm.com>,
        <yang.shi@...ux.alibaba.com>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>
Subject: Re: [PATCH] mm/huge_memory.c: use helper function
 migration_entry_to_page()

Hi:
On 2021/3/13 18:32, Miaohe Lin wrote:
> It's more recommended to use helper function migration_entry_to_page() to
> get the page via migration entry. We can also enjoy the PageLocked()
> check there.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

My bad! I have send this patch inside another patch series. Please ignore this one. Sorry for make noise! :(

> ---
>  mm/huge_memory.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index c00205e7c548..0a7a9884d0a2 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1693,7 +1693,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma,
>  
>  			VM_BUG_ON(!is_pmd_migration_entry(orig_pmd));
>  			entry = pmd_to_swp_entry(orig_pmd);
> -			page = pfn_to_page(swp_offset(entry));
> +			page = migration_entry_to_page(entry);
>  			flush_needed = 0;
>  		} else
>  			WARN_ONCE(1, "Non present huge pmd without pmd migration enabled!");
> @@ -2101,7 +2101,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
>  		swp_entry_t entry;
>  
>  		entry = pmd_to_swp_entry(old_pmd);
> -		page = pfn_to_page(swp_offset(entry));
> +		page = migration_entry_to_page(entry);
>  		write = is_write_migration_entry(entry);
>  		young = false;
>  		soft_dirty = pmd_swp_soft_dirty(old_pmd);
>