linux-kernel - Re: [PATCH v3 1/2] crypto: hisilicon/sec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 13 Mar 2021 09:30:43 +0800
From:   liulongfang <liulongfang@...wei.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     <wangzhou1@...ilicon.com>, <xuzaibo@...wei.com>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] crypto: hisilicon/sec - fixes some log printing
 style

On 2021/3/12 20:59, Herbert Xu wrote:
> On Thu, Mar 04, 2021 at 02:18:54PM +0800, Longfang Liu wrote:
>>
>> @@ -727,7 +725,7 @@ static void sec_cipher_pbuf_unmap(struct sec_ctx *ctx, struct sec_req *req,
>>  	struct aead_request *aead_req = req->aead_req.aead_req;
>>  	struct sec_cipher_req *c_req = &req->c_req;
>>  	struct sec_qp_ctx *qp_ctx = req->qp_ctx;
>> -	struct device *dev = SEC_CTX_DEV(ctx);
>> +	struct device *dev = ctx->dev;
>>  	int copy_size, pbuf_length;
>>  	int req_id = req->req_id;
>>  
>> @@ -737,11 +735,9 @@ static void sec_cipher_pbuf_unmap(struct sec_ctx *ctx, struct sec_req *req,
>>  		copy_size = c_req->c_len;
>>  
>>  	pbuf_length = sg_copy_from_buffer(dst, sg_nents(dst),
>> -				qp_ctx->res[req_id].pbuf,
>> -				copy_size);
>> -
>> +			qp_ctx->res[req_id].pbuf, copy_size);
>>  	if (unlikely(pbuf_length != copy_size))
>> -		dev_err(dev, "copy pbuf data to dst error!\n");
>> +		dev_err(ctx->dev, "copy pbuf data to dst error!\n");
>>  }
> 
> This triggers an unused warning on dev.  Please fix.
> 
> Thanks,
> Ok! I will check if this problem exists elsewhere.
Thanks,
Longfang