linux-kernel - Re: [PATCH] staging: andriod: ashmem: Declared file operation with const keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210313224205.ubnwecxyyas5qtvk@archlinux-ax161>
Date:   Sat, 13 Mar 2021 15:42:05 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     B K Karthik <bkkarthik@...u.pes.edu>
Cc:     namratajanawade <namrata.janawade@...il.com>,
        anupamakpatil123@...il.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        Hridya Valsaraju <hridya@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: andriod: ashmem: Declared file operation with
 const keyword

On Sat, Mar 13, 2021 at 10:59:43PM +0530, B K Karthik wrote:
> On Sat, Mar 13, 2021 at 10:57 PM namratajanawade
> <namrata.janawade@...il.com> wrote:
> >
> > Warning found by checkpatch.pl script.
> 
> That doesn't tell what you did or why you did it. Please write an
> appropriate commit description and resend the patch.
> 
> karthik

This patch will not even build, it has been sent several times before...

https://lore.kernel.org/r/20201016051111.1947-1-kirank.suren@gmail.com/
https://lore.kernel.org/r/20200328151523.17516-1-sandeshkenjanaashok@gmail.com/
https://lore.kernel.org/r/20201128121627.GA27317@worker-node1/
https://lore.kernel.org/r/20201227112645.256943-1-senguptaangshuman17@gmail.com/
https://lore.kernel.org/r/20201228051301.14983-1-jovin555@gmail.com/
https://lore.kernel.org/r/20210214023136.8916-1-thaiscamachoo@gmail.com/
https://lore.kernel.org/r/20210219101338.2670-1-amritkhera98@gmail.com/
https://lore.kernel.org/r/20210306063817.674041-1-nabil.ibn.mahmud@gmail.com/

I once considered adding a comment above it saying that it should not be
marked const but it is a good benchmark for seeing if people compile
their patches before sending them out.

Cheers,
Nathan