linux-kernel - Re: [PATCH] fs: overlayfs: Trivial typo fixes in the file inode.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Mar 2021 19:38:03 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>, miklos@...redi.hu,
        linux-unionfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: overlayfs: Trivial typo fixes in the file inode.c

On 3/12/21 7:30 PM, Bhaskar Chowdhury wrote:
> 
> s/peresistent/persistent/
> s/xatts/xattrs/  ---> this is a filesystem attribute, so, it spell like this.
> s/annotaion/annotation/
> 
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>

In the future, please drop "fs: " in the Subject:. Compare:

$ git log --oneline fs/overlayfs/
d46b7cd68336 ovl: plumb through flush method
335d3fc57941 ovl: implement volatile-specific fsync error behaviour
03fedf93593c ovl: skip getxattr of security labels
e04527fefba6 ovl: fix dentry leak in ovl_get_redirect
b854cc659dcb ovl: avoid deadlock on directory ioctl
554677b97257 ovl: perform vfs_getxattr() with mounter creds
9efb069de4ba ovl: add warning on user_ns mismatch
029a52ada6a7 overlayfs: do not mount on top of idmapped mounts
549c7297717c fs: make helpers idmap mount aware
6521f8917082 namei: prepare for idmapped mounts
9fe61450972d namei: introduce struct renamedata
c7c7a1a18af4 xattr: handle idmapped mounts
e65ce2a50cf6 acl: handle idmapped mounts
2f221d6f7b88 attr: handle idmapped mounts
21cb47be6fb9 inode: make init and permission helpers idmapped mount aware
47291baa8ddf namei: make permission helpers idmapped mount aware
0558c1bf5a08 capability: handle idmapped mounts
459c7c565ac3 ovl: unprivieged mounts
87b2c60c6127 ovl: do not get metacopy for userxattr
b6650dab404c ovl: do not fail because of O_NOATIME
6939f977c54a ovl: do not fail when setting origin xattr
2d2f2d7322ff ovl: user xattr
82a763e61e2b ovl: simplify file splice
89bdfaf93d91 ovl: make ioctl() safe
c846af050f94 ovl: check privs before decoding file handle


> ---
>  Note: The second change has nothing to do with dictionary words.
> 
>  fs/overlayfs/inode.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
> index d739e14c6814..e5588fc90a7d 100644
> --- a/fs/overlayfs/inode.c
> +++ b/fs/overlayfs/inode.c
> @@ -114,7 +114,7 @@ static int ovl_map_dev_ino(struct dentry *dentry, struct kstat *stat, int fsid)
>  		 * high xinobits, so we use high xinobits to partition the
>  		 * overlay st_ino address space. The high bits holds the fsid
>  		 * (upper fsid is 0). The lowest xinobit is reserved for mapping
> -		 * the non-peresistent inode numbers range in case of overflow.
> +		 * the non-persistent inode numbers range in case of overflow.
>  		 * This way all overlay inode numbers are unique and use the
>  		 * overlay st_dev.
>  		 */
> @@ -403,7 +403,7 @@ static bool ovl_can_list(struct super_block *sb, const char *s)
>  	if (ovl_is_private_xattr(sb, s))
>  		return false;
> 
> -	/* List all non-trusted xatts */
> +	/* List all non-trusted xattrs */
>  	if (strncmp(s, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) != 0)
>  		return true;
> 
> @@ -533,7 +533,7 @@ static const struct address_space_operations ovl_aops = {
>   * stackable i_mutex locks according to stack level of the super
>   * block instance. An overlayfs instance can never be in stack
>   * depth 0 (there is always a real fs below it).  An overlayfs
> - * inode lock will use the lockdep annotaion ovl_i_mutex_key[depth].
> + * inode lock will use the lockdep annotation ovl_i_mutex_key[depth].
>   *
>   * For example, here is a snip from /proc/lockdep_chains after
>   * dir_iterate of nested overlayfs:
> --

Acked-by: Randy Dunlap <rdunlap@...radead.org>


-- 
~Randy