linux-kernel - Re: [PATCH] gpu: drm: mediatek: delete redundant printing of return value

Open Source and information security mailing list archives

Message-ID: <CAAOTY__77A5ckALr=dxXK4zV3sbm_84_m9Bo0nBKBxPMMv2sxQ@mail.gmail.com>
Date:   Sun, 14 Mar 2021 09:42:34 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Wang Qing <wangqing@...o.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Matthias Brugger <matthias.bgg@...il.com>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpu: drm: mediatek: delete redundant printing of return value

Hi, Wang:

Wang Qing <wangqing@...o.com> 於 2021年3月13日 週六 下午3:48寫道：
>
> platform_get_irq() has already checked and printed the return value,
> the printing here is nothing special, it is not necessary at all.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index b05f900..0ac4962
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -751,10 +751,8 @@ static int mtk_dpi_probe(struct platform_device *pdev)
>         }
>
>         dpi->irq = platform_get_irq(pdev, 0);
> -       if (dpi->irq <= 0) {
> -               dev_err(dev, "Failed to get irq: %d\n", dpi->irq);
> +       if (dpi->irq <= 0)
>                 return -EINVAL;
> -       }
>
>         ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
>                                           NULL, &dpi->next_bridge);
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives