linux-kernel - Re: [PATCH] mips: kernel: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210314131037.GC5165@alpha.franken.de>
Date:   Sun, 14 Mar 2021 14:10:37 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Wang Qing <wangqing@...o.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: kernel: use DEFINE_DEBUGFS_ATTRIBUTE with
 debugfs_create_file_unsafe()

On Sat, Mar 13, 2021 at 11:33:48AM +0800, Wang Qing wrote:
> debugfs_create_file_unsafe does not protect the fops handed to it
> against file removal. DEFINE_DEBUGFS_ATTRIBUTE makes the fops aware of
> the file lifetime and thus protects it against removal.
> 
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
>  arch/mips/kernel/spinlock_test.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]