[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YE4FyiFgwM8cf5xe@shredder.lan>
Date: Sun, 14 Mar 2021 14:47:06 +0200
From: Ido Schimmel <idosch@...sch.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: rui.zhang@...el.com, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org, lukasz.luba@....com,
Jiri Pirko <jiri@...dia.com>, Ido Schimmel <idosch@...dia.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Amit Kucheria <amitk@...nel.org>,
"open list:MELLANOX ETHERNET SWITCH DRIVERS" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the
cooling device name
On Sun, Mar 14, 2021 at 12:13:29PM +0100, Daniel Lezcano wrote:
> We want to have any kind of name for the cooling devices as we do no
> longer want to rely on auto-numbering. Let's replace the cooling
> device's fixed array by a char pointer to be allocated dynamically
> when registering the cooling device, so we don't limit the length of
> the name.
>
> Rework the error path at the same time as we have to rollback the
> allocations in case of error.
>
> Tested with a dummy device having the name:
> "Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch"
>
> A village on the island of Anglesey (Wales), known to have the longest
> name in Europe.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> Reviewed-by: Lukasz Luba <lukasz.luba@....com>
Tested-by: Ido Schimmel <idosch@...dia.com>
Powered by blists - more mailing lists