linux-kernel - Re: [PATCH 1/3] xtensa: stop filling syscall array with sys_ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 14 Mar 2021 08:09:18 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Chris Zankel <chris@...kel.net>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@...ux-xtensa.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] xtensa: stop filling syscall array with sys_ni_syscall

On Mon, Mar 1, 2021 at 7:37 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> arch/xtensa/kernel/syscalls/syscalltbl.sh fills missing syscall numbers
> with sys_ni_syscall.
>
> So, the generated arch/xtensa/include/generated/asm/syscall_table.h
> has no hole.
>
> Hence, the line:
>
>   [0 ... __NR_syscalls - 1] = (syscall_t)&sys_ni_syscall,
>
> is meaningless.
>
> The number of generated __SYSCALL() macros is the same as __NR_syscalls
> (this is 442 as of v5.11).
>
> Hence, the array size, [__NR_syscalls] is unneeded.
>
> The designated initializer, '[nr] =', is also unneeded.
>
> This file does not need to know __NR_syscalls. Drop the unneeded
> <asm/unistd.h> include directive.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
>  arch/xtensa/kernel/syscall.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Thanks. I've applied the whole series to my xtensa tree.

-- 
Thanks.
-- Max