linux-kernel - [PATCH] staging: comedi: replace slash in name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Mar 2021 22:57:57 -0500
From:   Tong Zhang <ztong0001@...il.com>
To:     Ian Abbott <abbotti@....co.uk>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Tong Zhang <ztong0001@...il.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] staging: comedi: replace slash in name

request_irq() wont accept a name which contains slash so we need to
repalce it with something else -- otherwise it will trigger a warning
and the entry in /proc/irq/ will not be created

[    1.565966] name 'pci-das6402/16'
[    1.566149] WARNING: CPU: 0 PID: 184 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0
[    1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0
[    1.574200] Call Trace:
[    1.574722]  proc_mkdir+0x18/0x20
[    1.576629]  request_threaded_irq+0xfe/0x160
[    1.576859]  auto_attach+0x60a/0xc40 [cb_pcidas64]

Signed-off-by: Tong Zhang <ztong0001@...il.com>
---
 drivers/staging/comedi/drivers/cb_pcidas64.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index fa987bb0e7cd..662d6ffb8f60 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -677,7 +677,7 @@ static const int bytes_in_sample = 2;
 
 static const struct pcidas64_board pcidas64_boards[] = {
 	[BOARD_PCIDAS6402_16] = {
-		.name		= "pci-das6402/16",
+		.name		= "pci-das6402-16",
 		.ai_se_chans	= 64,
 		.ai_bits	= 16,
 		.ai_speed	= 5000,
@@ -693,7 +693,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
 		.has_8255	= 1,
 	},
 	[BOARD_PCIDAS6402_12] = {
-		.name		= "pci-das6402/12",	/* XXX check */
+		.name		= "pci-das6402-12",	/* XXX check */
 		.ai_se_chans	= 64,
 		.ai_bits	= 12,
 		.ai_speed	= 5000,
@@ -709,7 +709,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
 		.has_8255	= 1,
 	},
 	[BOARD_PCIDAS64_M1_16] = {
-		.name		= "pci-das64/m1/16",
+		.name		= "pci-das64-m1-16",
 		.ai_se_chans	= 64,
 		.ai_bits	= 16,
 		.ai_speed	= 1000,
@@ -725,7 +725,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
 		.has_8255	= 1,
 	},
 	[BOARD_PCIDAS64_M2_16] = {
-		.name = "pci-das64/m2/16",
+		.name = "pci-das64-m2-16",
 		.ai_se_chans	= 64,
 		.ai_bits	= 16,
 		.ai_speed	= 500,
@@ -741,7 +741,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
 		.has_8255	= 1,
 	},
 	[BOARD_PCIDAS64_M3_16] = {
-		.name		= "pci-das64/m3/16",
+		.name		= "pci-das64-m3-16",
 		.ai_se_chans	= 64,
 		.ai_bits	= 16,
 		.ai_speed	= 333,
@@ -984,7 +984,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
 		.has_8255	= 0,
 	},
 	[BOARD_PCIDAS4020_12] = {
-		.name		= "pci-das4020/12",
+		.name		= "pci-das4020-12",
 		.ai_se_chans	= 4,
 		.ai_bits	= 12,
 		.ai_speed	= 50,
-- 
2.25.1