linux-kernel - Re: [PATCH][next] bus: mhi: core: remove redundant initialization of variables state and ee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Mar 2021 09:21:19 +0100
From:   Loic Poulain <loic.poulain@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Manivannan Sadhasivam <mani@...nel.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] bus: mhi: core: remove redundant initialization of
 variables state and ee

On Thu, 11 Mar 2021 at 12:18, Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> The variables state and ee are being initialized with values that
> are never read and are being updated later with a new values. The
> initializations are redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Loic Poulain <loic.poulain@...aro.org>

> ---
>  drivers/bus/mhi/core/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index 2c61dfd01353..3faf8bade520 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv)
>  {
>         struct mhi_controller *mhi_cntrl = priv;
>         struct device *dev = &mhi_cntrl->mhi_dev->dev;
> -       enum mhi_state state = MHI_STATE_MAX;
> +       enum mhi_state state;
>         enum mhi_pm_state pm_state = 0;
> -       enum mhi_ee_type ee = MHI_EE_MAX;
> +       enum mhi_ee_type ee;
>
>         write_lock_irq(&mhi_cntrl->pm_lock);
>         if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) {
> --
> 2.30.2
>