linux-kernel - Re: [PATCH] cpufreq: cppc: simplify default delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210315045302.hdmu5ca4f7z3y5ki@vireshk-i7>
Date:   Mon, 15 Mar 2021 10:23:02 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Tom Saeger <tom.saeger@...cle.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Prashanth Prakash <pprakash@...eaurora.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: cppc: simplify default delay_us setting

On 12-03-21, 19:50, Tom Saeger wrote:
> Simplify case when setting default in cppc_cpufreq_get_transition_delay_us.
> 
> Signed-off-by: Tom Saeger <tom.saeger@...cle.com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 8a482c434ea6..2f769b1630c5 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -216,26 +216,16 @@ static unsigned int cppc_cpufreq_get_transition_delay_us(unsigned int cpu)
>  {
>  	unsigned long implementor = read_cpuid_implementor();
>  	unsigned long part_num = read_cpuid_part_number();
> -	unsigned int delay_us = 0;
>  
>  	switch (implementor) {
>  	case ARM_CPU_IMP_QCOM:
>  		switch (part_num) {
>  		case QCOM_CPU_PART_FALKOR_V1:
>  		case QCOM_CPU_PART_FALKOR:
> -			delay_us = 10000;
> -			break;
> -		default:
> -			delay_us = cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
> -			break;
> +			return 10000;
>  		}
> -		break;
> -	default:
> -		delay_us = cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
> -		break;
>  	}
> -
> -	return delay_us;
> +	return cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
>  }

Applied. Thanks.

-- 
viresh