linux-kernel - Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANRm+CwMz8DBDNjcUyhZmv5vSsX47CiBEd0G8UQNEQextju6jA@mail.gmail.com>
Date:   Mon, 15 Mar 2021 14:56:17 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Sean Christopherson <seanjc@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>, kvm <kvm@...r.kernel.org>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Mark Rutland <mark.rutland@....com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

On Sat, 13 Mar 2021 at 17:33, Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> On 13/03/21 01:57, Wanpeng Li wrote:
> >> A third option would be to split the paths.  In the end, it's only the ptr/val
> >> line that's shared.
> > I just sent out a formal patch for my alternative fix, I think the
> > whole logic in kvm_wait is more clear w/ my version.
> >
>
> I don't know, having three "if"s in 10 lines of code is a bit daunting.

Fair enough, just sent out v3 per Sean's suggestion.

    Wanpeng