linux-kernel - [PATCH] softirq: Be more verbose on t->state BUG()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210315154421.11463-1-erosca@de.adit-jv.com>
Date:   Mon, 15 Mar 2021 16:44:21 +0100
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>, Will Deacon <will@...nel.org>,
        Frederic Weisbecker <frederic@...nel.org>,
        Jiafei Pan <Jiafei.Pan@....com>,
        Romain Perier <romain.perier@...il.com>
CC:     Andrew Gabbasov <andrew_gabbasov@...tor.com>,
        Dirk Behme <dirk.behme@...bosch.com>,
        Eugeniu Rosca <roscaeugeniu@...il.com>,
        Eugeniu Rosca <erosca@...adit-jv.com>
Subject: [PATCH] softirq: Be more verbose on t->state BUG()

From: Dirk Behme <dirk.behme@...bosch.com>

In case this BUG() is hit, it helps debugging a lot to get an idea
what tasklet is the root cause. So, be slightly more verbose here.

Signed-off-by: Dirk Behme <dirk.behme@...bosch.com>
Signed-off-by: Eugeniu Rosca <erosca@...adit-jv.com>
---
 kernel/softirq.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 9908ec4a9bfe..a6b602ad48d6 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -550,9 +550,13 @@ static void tasklet_action_common(struct softirq_action *a,
 
 		if (tasklet_trylock(t)) {
 			if (!atomic_read(&t->count)) {
-				if (!test_and_clear_bit(TASKLET_STATE_SCHED,
-							&t->state))
+				if (!test_and_clear_bit(TASKLET_STATE_SCHED, &t->state)) {
+					if (t->use_callback)
+						pr_emerg("tasklet failed, cb: %pS\n", t->callback);
+					else
+						pr_emerg("tasklet failed, func: %pS\n", t->func);
 					BUG();
+				}
 				if (t->use_callback)
 					t->callback(t);
 				else
-- 
2.29.0