linux-kernel - Re: [PATCH] pcmcia: ds: Remove if with always false condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YE8L7BLdsQCzgUGs@light.dominikbrodowski.net>
Date:   Mon, 15 Mar 2021 08:25:32 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] pcmcia: ds: Remove if with always false condition

Am Mon, Mar 01, 2021 at 06:38:47PM +0100 schrieb Uwe Kleine-König:
> pcmcia_device_remove() is only ever called by the driver core with
> dev->driver pointing to a valid driver. (And even if dev->driver was
> NULL, p_drv wouldn't be NULL as p_drv is assigned as follows:
> 
> 	p_drv = to_pcmcia_drv(dev->driver);
> 
> and to_pcmcia_drv is a container_of operation on struct
> pcmcia_driver::drv which isn't the first member in struct
> pcmcia_driver.)
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Applied to pcmcia-next, thanks.

	Dominik