linux-kernel - Re: [PATCH v2 07/27] perf evlist: Hybrid event uses its own cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Mar 2021 09:25:18 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v2 07/27] perf evlist: Hybrid event uses its own cpus

Hi Jiri,

On 3/13/2021 3:15 AM, Jiri Olsa wrote:
> On Thu, Mar 11, 2021 at 03:07:22PM +0800, Jin Yao wrote:
>> On hybrid platform, atom events can be only enabled on atom CPUs. Core
>> events can be only enabled on core CPUs. So for a hybrid event, it can
>> be only enabled on it's own CPUs.
>>
>> But the problem for current perf is, the cpus for evsel (via PMU sysfs)
>> have been merged to evsel_list->core.all_cpus. It might be all CPUs.
>>
>> So we need to figure out one way to let the hybrid event only use it's
>> own CPUs.
>>
>> The idea is to create a new evlist__invalidate_all_cpus to invalidate
>> the evsel_list->core.all_cpus then evlist__for_each_cpu returns cpu -1
>> for hybrid evsel. If cpu is -1, hybrid evsel will use it's own cpus.
> 
> that's wild.. I don't understand when you say we don't have
> cpus for evsel, because they have been merged.. each evsel
> has evsel->core.own_cpus coming from pmu->cpus, right?
> 
> why can't you just filter out cpus that are in there?
> 
> jirka
> 

Yes, you're right. This patch is wide and actually it's not very necessary.

The current framework has processed the cpus for evsel well even for hybrid evsel. So this patch can 
be dropped.

Thanks
Jin Yao