lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <62f003b9cf2bc1ae238689ea811b870d@walle.cc>
Date:   Mon, 15 Mar 2021 18:39:31 +0100
From:   Michael Walle <michael@...le.cc>
To:     Sameer Pujar <spujar@...dia.com>
Cc:     broonie@...nel.org, lgirdwood@...il.com, oder_chiou@...ltek.com,
        jonathanh@...dia.com, kuninori.morimoto.gx@...esas.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, thierry.reding@...il.com,
        sharadg@...dia.com
Subject: Re: [PATCH 1/2] ASoC: simple-card-utils: Do not handle device clock

Am 2021-03-15 18:31, schrieb Sameer Pujar:
> This reverts commit 1e30f642cf29 ("ASoC: simple-card-utils: Fix device
> module clock"). The original patch ended up breaking following 
> platform,
> which depends on set_sysclk() to configure internal PLL on wm8904 codec
> and expects simple-card-utils to not update the MCLK rate.
>  - 
> "arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts"
> 
> It would be best if codec takes care of setting MCLK clock via DAI
> set_sysclk() callback.
> 
> Reported-by: Michael Walle <michael@...le.cc>
> Suggested-by: Mark Brown <broonie@...nel.org>
> Suggested-by: Michael Walle <michael@...le.cc>
> Fixes: 1e30f642cf29 ("ASoC: simple-card-utils: Fix device module 
> clock")
> Signed-off-by: Sameer Pujar <spujar@...dia.com>

Thanks!

Tested-by: Michael Walle <michael@...le.cc>

-michael

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ